Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert jetty-httpclient Groovy tests to Java #9072

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Convert jetty-httpclient Groovy tests to Java #9072

merged 1 commit into from
Jul 31, 2023

Conversation

pg-yang
Copy link
Contributor

@pg-yang pg-yang commented Jul 28, 2023

related #7195

@pg-yang pg-yang requested a review from a team July 28, 2023 03:05
mateuszrzeszutek
mateuszrzeszutek reviewed Jul 28, 2023
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pg-yang !
This is looking great, I left just a couple minor comments.

...java/io/opentelemetry/instrumentation/jetty/httpclient/v9_2/JettyHttpClient9LibraryTest.java Outdated Show resolved Hide resolved
...opentelemetry/javaagent/instrumentation/jetty/httpclient/v9_2/JettyHttpClient9AgentTest.java Outdated Show resolved Hide resolved
...in/java/io/opentelemetry/instrumentation/jetty/httpclient/v9_2/AbstractJettyClient9Test.java Outdated Show resolved Hide resolved
...in/java/io/opentelemetry/instrumentation/jetty/httpclient/v9_2/AbstractJettyClient9Test.java Outdated Show resolved Hide resolved
@pg-yang
Copy link
Contributor Author

pg-yang commented Jul 28, 2023

Hello, thanks for your suggestions. I think it's OK for now. And I have rebased the branch

mateuszrzeszutek
mateuszrzeszutek approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pg-yang !

@mateuszrzeszutek mateuszrzeszutek merged commit 976dfb2 into open-telemetry:main Jul 31, 2023
44 checks passed
@mateuszrzeszutek mateuszrzeszutek mentioned this pull request Jul 31, 2023
Open
@pg-yang pg-yang deleted the jetty-client-test branch July 31, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pg-yang @mateuszrzeszutek