Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix armeria server instrumentation for http2 #9723

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Oct 19, 2023

Hopefully resolves #9695
The issue here is that for armeria sever javaagent instrumentation the server span is created by netty instrumentation, but we don't have netty instrumentation for http2. This pr adds a check that when a server span was not created by netty instrumentation we'll use aremeria liberary instrumentation. To use armeria library instrumentation I restored code removed in #8281

@laurit laurit requested a review from a team October 19, 2023 16:18
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I'm surprised we haven't had similar reports about webflux

@trask trask merged commit 79f2726 into open-telemetry:main Oct 19, 2023
47 checks passed
@laurit laurit deleted the armeria-http2-server branch October 19, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't found the trace chain between Armeria service when use opentelemetry as java agent
3 participants