Add instrumentation for vert.x redis client #9838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
force-pushed
the
vertx-redis-client
branch
from
93464ed to
52d5ffb
Compare
breedx-splk
reviewed
Dec 5, 2023
...t/java/io/opentelemetry/javaagent/instrumentation/vertx/v4_0/redis/VertxRedisClientTest.java
Outdated
Show resolved
Hide resolved
breedx-splk
approved these changes
Dec 5, 2023
...t/java/io/opentelemetry/javaagent/instrumentation/vertx/v4_0/redis/VertxRedisClientTest.java
Outdated
Show resolved
Hide resolved
...t/java/io/opentelemetry/javaagent/instrumentation/vertx/v4_0/redis/VertxRedisClientTest.java
Outdated
Show resolved
Hide resolved
...emetry/javaagent/instrumentation/vertx/v4_0/redis/VertxRedisClientInstrumentationModule.java
Show resolved
Hide resolved
.../io/opentelemetry/javaagent/instrumentation/vertx/v4_0/redis/VertxRedisClientSingletons.java
Outdated
Show resolved
Hide resolved
...emetry/javaagent/instrumentation/vertx/v4_0/redis/VertxRedisClientInstrumentationModule.java
Show resolved
Hide resolved
.../io/opentelemetry/javaagent/instrumentation/vertx/v4_0/redis/VertxRedisClientSingletons.java
Outdated
Show resolved
Hide resolved
...metry/javaagent/instrumentation/vertx/v4_0/redis/RedisConnectionProviderInstrumentation.java
Show resolved
Hide resolved
...x/vertx-redis-client-4.0/javaagent/src/main/java/io/vertx/redis/client/impl/RequestUtil.java
Show resolved
Hide resolved
laurit
force-pushed
the
vertx-redis-client
branch
from
52d5ffb to
8b38aea
Compare
trask
approved these changes
Dec 6, 2023
...ava/io/opentelemetry/javaagent/instrumentation/vertx/v4_0/redis/VertxRedisClientRequest.java
Outdated
Show resolved
Hide resolved
laurit
force-pushed
the
vertx-redis-client
branch
from
8b38aea to
d5eb190
Compare
zeitlinger
pushed a commit
to zeitlinger/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds instrumentation for vert.x redis client. Instrumentation is added only for sending commands one by one, support for batch commands is not implemented.