Move kafka metrics to separate instrumentation module #9862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
commented
Nov 14, 2023
|
|
||
| public final class KafkaMetricsUtil { | ||
| private static final String INSTRUMENTATION_NAME = "io.opentelemetry.kafka-clients-0.11"; | ||
| private static final boolean METRICS_ENABLED = |
There was a problem hiding this comment.
should we remove this or keep it for backwards compatibility?
There was a problem hiding this comment.
Deprecate, remove in the next release?
mateuszrzeszutek
approved these changes
Nov 15, 2023
|
|
||
| public final class KafkaMetricsUtil { | ||
| private static final String INSTRUMENTATION_NAME = "io.opentelemetry.kafka-clients-0.11"; | ||
| private static final boolean METRICS_ENABLED = |
There was a problem hiding this comment.
Deprecate, remove in the next release?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9518
This should allow users to disable tracing for kafka but enable metrics.