Authority from request when HttpHost is null #9990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Dec 1, 2023
Comment on lines
+94
to
+113
| @Nested | ||
| class ApacheClientNullHttpHostRequestTest extends AbstractTest { | ||
| @Override | ||
| ClassicHttpRequest createRequest(String method, URI uri) { | ||
| // also testing with an absolute path below | ||
| return new BasicClassicHttpRequest(method, HttpHost.create(uri), fullPathFromUri(uri)); | ||
| } | ||
|
|
||
| @Override | ||
| ClassicHttpResponse doExecuteRequest(ClassicHttpRequest request, URI uri) throws Exception { | ||
| return getClient(uri).execute(null, request); | ||
| } | ||
|
|
||
| @Override | ||
| void executeRequestWithCallback(ClassicHttpRequest request, URI uri, HttpClientResult result) | ||
| throws Exception { | ||
| getClient(uri).execute(null, request, new ResponseHandler(result)); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
thanks for figuring out how to add a test case for it!
laurit
approved these changes
Dec 3, 2023
zeitlinger
pushed a commit
to zeitlinger/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 12, 2023
Closed
laurit
pushed a commit
to laurit/opentelemetry-java-instrumentation
that referenced
this pull request
Jan 10, 2024
trask
pushed a commit
that referenced
this pull request
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9987