Add a DelegatingSpanData that can be used to wrap SpanData with different data. #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2020 12:00
anuraaga
changed the title
jkwatson
reviewed
Aug 5, 2020
| * Attributes.Builder newAttributes = Attributes.newBuilder(); | ||
| * delegate.getAttributes().forEach(newAttributes::setAttribute); | ||
| * newAttributes.setAttribute("client_type", clientType); | ||
| * attributes = newAttributes.build(); |
There was a problem hiding this comment.
yeah, this was what I was thinking, @iNikem . It's not super pretty, but could be made much nicer with a toBuilder on the Attributes class, like we have on Labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1502.
It's unfortunate since it means we have three implementations of
SpanData-SpanWrapper,TestSpanData,DecoratingSpanData. Perhaps it allows squeezing a bit of performance but wonder if the wrapping concept is really worth it here in the first place.Fixes #1321
/cc @iNikem