-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ParentOrElse to ParentBased and generalize to support all cases #1577
Rename ParentOrElse to ParentBased and generalize to support all cases #1577
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1577 +/- ##
============================================
+ Coverage 86.85% 86.88% +0.03%
- Complexity 1392 1393 +1
============================================
Files 162 162
Lines 5369 5397 +28
Branches 513 519 +6
============================================
+ Hits 4663 4689 +26
- Misses 523 524 +1
- Partials 183 184 +1
Continue to review full report at Codecov.
|
Just renaming is insufficient. https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#parentbased |
yes, I don't think this will close #1572, but I think it's a step along the way. If we don't close #1572 with this PR, are you ok with it as a first step, @Oberon00 ? |
@dengliming can you either 1) remove the Thanks! |
@jkwatson Sorry. just forgot it. : ) . I will do the implementation fully addresses the spec recently. Can you assign to me? |
Done, and thanks for taking that on! |
sdk/tracing/src/main/java/io/opentelemetry/sdk/trace/Samplers.java
Outdated
Show resolved
Hide resolved
sdk/tracing/src/test/java/io/opentelemetry/sdk/trace/SamplersTest.java
Outdated
Show resolved
Hide resolved
This is looking pretty good to me. Thanks for putting in the work! |
sdk/tracing/src/main/java/io/opentelemetry/sdk/trace/Samplers.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, thanks
sdk/tracing/src/main/java/io/opentelemetry/sdk/trace/Samplers.java
Outdated
Show resolved
Hide resolved
sdk/tracing/src/main/java/io/opentelemetry/sdk/trace/Samplers.java
Outdated
Show resolved
Hide resolved
sdk/tracing/src/main/java/io/opentelemetry/sdk/trace/Samplers.java
Outdated
Show resolved
Hide resolved
sdk/tracing/src/main/java/io/opentelemetry/sdk/trace/Samplers.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry noticed one more small comment on the javadoc
sdk/tracing/src/main/java/io/opentelemetry/sdk/trace/Samplers.java
Outdated
Show resolved
Hide resolved
sdk/tracing/src/main/java/io/opentelemetry/sdk/trace/Samplers.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
closes #1572