Add incubator module with utilities for mutating SpanData. #1625
Conversation
anuraaga
requested review from
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
pavolloffay,
thisthat and
tylerbenson
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1625 +/- ##
============================================
- Coverage 85.45% 85.41% -0.04%
Complexity 1382 1382
============================================
Files 164 164
Lines 5418 5418
Branches 556 556
============================================
- Hits 4630 4628 -2
- Misses 588 589 +1
- Partials 200 201 +1
Continue to review full report at Codecov.
|
| // type. | ||
| @Immutable | ||
| @AutoValue | ||
| public abstract class SpanData implements io.opentelemetry.sdk.trace.data.SpanData { |
There was a problem hiding this comment.
Can we name this something else, so we don't have the name collision, requiring using FQNs for hte interface?
There was a problem hiding this comment.
Not sure why I missed this review, sorry! I could have sworn I added a comment in description about it but didn't - I agree, but couldn't come up with a better name :( Any ideas?
There was a problem hiding this comment.
BuildableSpanData? SpanDataExtender? BuiltSpanData?
Maybe just SpanDataBuilder for now, since it's really a temporary move to see if this is the best approach?
|
Thanks! Just one small question about naming the one with the builder. |
|
@anuraaga any updates on the naming here? |
|
Is this really urgent? |
It's not, but I'd rather not have open PRs lying around, even if they aren't technically needed for GA. |
… into incubator-spandata
|
@jkwatson Yup sorry for the slowness, finally renamed. |
Sorry for the huge delay on this.
For #1321