Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the TraceFlags isSampled boolean into the SpanContext #1628

Merged
merged 6 commits into from
Sep 14, 2020

Conversation

jkwatson
Copy link
Contributor

@jkwatson jkwatson commented Sep 8, 2020

Resolves #1603

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #1628 into master will decrease coverage by 0.05%.
The diff coverage is 95.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1628      +/-   ##
============================================
- Coverage     86.61%   86.55%   -0.06%     
+ Complexity     1408     1397      -11     
============================================
  Files           163      163              
  Lines          5529     5497      -32     
  Branches        553      552       -1     
============================================
- Hits           4789     4758      -31     
+ Misses          544      543       -1     
  Partials        196      196              
Impacted Files Coverage Δ Complexity Δ
...java/io/opentelemetry/sdk/trace/data/SpanData.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...telemetry/sdk/trace/export/BatchSpanProcessor.java 90.20% <0.00%> (ø) 8.00 <1.00> (ø)
...ions/trace/jaeger/sampler/RateLimitingSampler.java 70.83% <50.00%> (ø) 7.00 <3.00> (ø)
.../main/java/io/opentelemetry/trace/SpanContext.java 90.00% <100.00%> (+2.50%) 15.00 <4.00> (+4.00)
...c/main/java/io/opentelemetry/trace/TraceFlags.java 100.00% <100.00%> (+8.10%) 6.00 <5.00> (-14.00) ⬆️
...ntelemetry/trace/propagation/HttpTraceContext.java 96.11% <100.00%> (ø) 29.00 <0.00> (ø)
...xtensions/trace/propagation/AwsXRayPropagator.java 87.20% <100.00%> (+0.15%) 26.00 <0.00> (+1.00)
...opagation/B3PropagatorInjectorMultipleHeaders.java 91.66% <100.00%> (ø) 4.00 <0.00> (ø)
.../propagation/B3PropagatorInjectorSingleHeader.java 95.65% <100.00%> (-0.35%) 5.00 <0.00> (ø)
...telemetry/extensions/trace/propagation/Common.java 72.22% <100.00%> (-2.78%) 10.00 <0.00> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13fd58...6b83096. Read the comment docs.

…tensions/trace/propagation/AwsXRayPropagator.java

Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
@jkwatson jkwatson added the API API related issues label Sep 9, 2020
@jkwatson
Copy link
Contributor Author

jkwatson commented Sep 9, 2020

@bogdandrutu @carlosalberto this is an API change. If you're interested, please review!

@carlosalberto
Copy link
Contributor

Overall LGTM, thanks for this PR!

@anuraaga
Copy link
Contributor

LGTM makes sense to discuss byte vs boolean separately.

@jkwatson jkwatson merged commit ddb3897 into open-telemetry:master Sep 14, 2020
@jkwatson jkwatson deleted the flags_in_context branch September 14, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider moving TraceFlags into the SpanContext
6 participants