-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the TraceFlags isSampled boolean into the SpanContext #1628
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1628 +/- ##
============================================
- Coverage 86.61% 86.55% -0.06%
+ Complexity 1408 1397 -11
============================================
Files 163 163
Lines 5529 5497 -32
Branches 553 552 -1
============================================
- Hits 4789 4758 -31
+ Misses 544 543 -1
Partials 196 196 Continue to review full report at Codecov.
|
...ropagators/src/main/java/io/opentelemetry/extensions/trace/propagation/JaegerPropagator.java
Outdated
Show resolved
Hide resolved
...opagators/src/main/java/io/opentelemetry/extensions/trace/propagation/AwsXRayPropagator.java
Outdated
Show resolved
Hide resolved
…tensions/trace/propagation/AwsXRayPropagator.java Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
@bogdandrutu @carlosalberto this is an API change. If you're interested, please review! |
Overall LGTM, thanks for this PR! |
LGTM makes sense to discuss byte vs boolean separately. |
Resolves #1603