Migrate usage of gRPC context to OTel context. #1751
Conversation
anuraaga
requested review from
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
pavolloffay,
thisthat and
tylerbenson
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1751 +/- ##
============================================
+ Coverage 85.21% 85.56% +0.34%
- Complexity 1351 1354 +3
============================================
Files 166 165 -1
Lines 5276 5265 -11
Branches 549 549
============================================
+ Hits 4496 4505 +9
+ Misses 577 560 -17
+ Partials 203 200 -3
Continue to review full report at Codecov.
|
| In-process propagation leverages [gRPC Context](https://grpc.github.io/grpc-java/javadoc/io/grpc/Context.html), | ||
| a well established context propagation library, contained in a small artifact, which is non-dependent on the | ||
| entire gRPC engine. | ||
|
|
There was a problem hiding this comment.
Is it worth replacing this with a comment about our own context implementation, rather than just deleting it?
There was a problem hiding this comment.
I wasn't sure how to phrase it. I read this sentence as justifying the external dependency because it is "a small artifact, which is non-dependent on the entire gRPC engine." for people that might worry about that, rather than anything particularly interesting. Let me know if you have any suggestion on how to replace this, I'll put it in.
There was a problem hiding this comment.
it's fine for now. I was just wondering if people might be interested in how our in-process propagation was implemented.
|
Merging! 🎉 |
Merging should be held off until next release to give this code some time to bake in snapshots but sending it out now.
Fixes #575