Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix specification link in SemanticAttributes.java #1763

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Fix specification link in SemanticAttributes.java #1763

merged 2 commits into from
Oct 6, 2020

Conversation

dengliming
Copy link
Member

closes #1757

jkwatson
jkwatson approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

❗ No coverage uploaded for pull request head (fix_link@a7a75b0). Click here to learn what that means.
The diff coverage is n/a.

@bogdandrutu bogdandrutu merged commit 1a73964 into open-telemetry:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@jkwatson jkwatson jkwatson approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@arminru arminru Awaiting requested review from arminru

@carlosalberto carlosalberto Awaiting requested review from carlosalberto

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@thisthat thisthat Awaiting requested review from thisthat

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SemanticAttributes.java refers to non-existing semantic conventions
3 participants
@dengliming @jkwatson @bogdandrutu