Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode enums as numbers in logging OTLP exporters #4783

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Encode enums as numbers in logging OTLP exporters #4783

merged 1 commit into from
Oct 17, 2022

Conversation

jack-berg
Copy link
Member

Implements spec PR #2758, which prohibits enum string values in OTLP JSON encoding.

@jack-berg jack-berg requested a review from a team September 26, 2022 19:29
@jkwatson
Copy link
Contributor

jkwatson commented Oct 5, 2022

Nice. so now the logs will be even less human readable. :(

@jack-berg
Copy link
Member Author

Nice. so now the logs will be even less human readable. :(

But... there will be less bikeshedding over the names of enum values because we'll be able to change them without breaking. 😁

jkwatson
jkwatson approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is to spec, then 🆗 . I don't know who will ever end up using this exporter, though. :(

@jack-berg jack-berg merged commit 5be58c5 into open-telemetry:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@jkwatson jkwatson jkwatson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jack-berg @jkwatson @mateuszrzeszutek