-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make description of Samplers Locale independent #4887
Conversation
Codecov ReportBase: 90.83% // Head: 90.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4887 +/- ##
============================================
- Coverage 90.83% 90.83% -0.01%
- Complexity 4856 4859 +3
============================================
Files 556 556
Lines 14474 14483 +9
Branches 1410 1410
============================================
+ Hits 13148 13155 +7
- Misses 908 909 +1
- Partials 418 419 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
...r/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/RateLimitingSampler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment. Thanks!
Changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jack-berg what do you think about calculating it once in the constructor? getDescription
is not supposed to be called a lot, but just in case...
and I think the extra small amount of memory is ok since there shouldn't be a huge number of Sampler instances
Fixes: #4880