Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTracing Shim: Full multiple parent support. #4916

Merged

Conversation

carlosalberto
Copy link
Contributor

This includes:

  • The Baggage union of ALL parents is used.
  • All parents are added as Links, in order to preserve the OpenTracing reference type as an attribute (either CHILD_OF or FOLLOWS_FROM).

Fixes #4906
Fixes #4907

This includes:

* The Baggage union of ALL parents is used.
* All parents are added as Links, in order to preserve
  the OpenTracing reference type as an attribute
  (either CHILD_OF or FOLLOWS_FROM).
@carlosalberto carlosalberto requested a review from a team November 3, 2022 14:17
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 90.83% // Head: 90.98% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (e24dcb8) compared to base (21d5597).
Patch coverage: 96.29% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4916      +/-   ##
============================================
+ Coverage     90.83%   90.98%   +0.14%     
+ Complexity     4857     4830      -27     
============================================
  Files           556      545      -11     
  Lines         14475    14415      -60     
  Branches       1410     1388      -22     
============================================
- Hits          13149    13116      -33     
+ Misses          908      895      -13     
+ Partials        418      404      -14     
Impacted Files Coverage Δ
...opentelemetry/opentracingshim/SpanBuilderShim.java 88.28% <96.29%> (+10.38%) ⬆️
...metry/extension/aws/AwsConfigurablePropagator.java 0.00% <0.00%> (-100.00%) ⬇️
...try/exporter/zipkin/ZipkinSpanExporterBuilder.java 97.72% <0.00%> (-2.28%) ⬇️
.../java/io/opentelemetry/sdk/resources/Resource.java 90.56% <0.00%> (-1.89%) ⬇️
...telemetry/sdk/trace/export/BatchSpanProcessor.java 91.03% <0.00%> (-1.38%) ⬇️
...opentelemetry/extension/aws/AwsXrayPropagator.java 90.64% <0.00%> (-0.72%) ⬇️
...xporter/internal/okhttp/OkHttpExporterBuilder.java 91.37% <0.00%> (-0.15%) ⬇️
...va/io/opentelemetry/sdk/logs/SdkLoggerBuilder.java 100.00% <0.00%> (ø)
...a/io/opentelemetry/sdk/logs/SdkLoggerProvider.java 100.00% <0.00%> (ø)
...a/io/opentelemetry/sdk/trace/SdkTracerBuilder.java 100.00% <0.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor suggestions but looks good

carlosalberto and others added 4 commits November 7, 2022 13:59
…m/SpanBuilderShim.java

Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
…m/SpanBuilderShim.java

Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
…m/SpanBuilderShim.java

Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
@carlosalberto
Copy link
Contributor Author

Thanks for the review @jack-berg - applied the feedback. The only remaining item is the private access modifier for the (internal) enum ;)

@jack-berg jack-berg merged commit f83def7 into open-telemetry:main Nov 9, 2022
dmarkwat pushed a commit to dmarkwat/opentelemetry-java that referenced this pull request Dec 30, 2022
* Full multiple parent support.

This includes:

* The Baggage union of ALL parents is used.
* All parents are added as Links, in order to preserve
  the OpenTracing reference type as an attribute
  (either CHILD_OF or FOLLOWS_FROM).

* Update opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java

Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>

* Update opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java

Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>

* Update opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java

Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>

* Apply feedback.

* More feedback.

Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants