Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename otel.config.file to otel.experimental.config.file #6396

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented Apr 17, 2024

Reflects naming in spec PR: open-telemetry/opentelemetry-specification#3948

The experimental prefix in the name makes it clear to users that the behavior of how file configuration is subject to breaking changes.

This PR removes support for otel.config.file. If it is set, we log a warning.

@jack-berg jack-berg requested a review from a team April 17, 2024 17:08
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.06%. Comparing base (8937a10) to head (f2b6a2c).
Report is 6 commits behind head on main.

Files Patch % Lines
...nfigure/AutoConfiguredOpenTelemetrySdkBuilder.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6396      +/-   ##
============================================
- Coverage     91.10%   91.06%   -0.05%     
- Complexity     5772     5773       +1     
============================================
  Files           627      627              
  Lines         16852    16858       +6     
  Branches       1720     1722       +2     
============================================
- Hits          15353    15351       -2     
- Misses         1005     1010       +5     
- Partials        494      497       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit feef408 into open-telemetry:main Apr 18, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants