Refactor metrics to remove MeterSharedState #6845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting to think about how to allow for updating SDK configuration. Starting with metrics because traces and logs are a cake walk in comparison. While doing some analysis I realized that MeterSharedState is a silly concept - all of its logic and state can just be held directly on the respective SdkMeter.
This reduces complexity and makes it easier to reason over.