Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

chore: move span method for context in trace API #40 #47

Merged
merged 2 commits into from
May 2, 2021

Conversation

vmarchaud
Copy link
Member

  • I moved both [sg]etSpan/[sg]etSpanContext utils into the trace API
  • I also moved [sg]etBaggage to the baggage folder (next to createBaggage)
    • As discussed in the SIG, we should think about the place for baggage utils, i think it makes more sense in the propagation API

Fixes #40

@codecov
Copy link

codecov bot commented Apr 25, 2021

Codecov Report

Merging #47 (8e3b8da) into main (e938882) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   94.65%   94.72%   +0.07%     
==========================================
  Files          39       40       +1     
  Lines         505      512       +7     
  Branches       80       80              
==========================================
+ Hits          478      485       +7     
  Misses         27       27              
Impacted Files Coverage Δ
src/context/context.ts 82.35% <ø> (-10.15%) ⬇️
src/api/trace.ts 96.55% <100.00%> (+0.71%) ⬆️
src/baggage/index.ts 100.00% <100.00%> (ø)
src/trace/NoopTracer.ts 95.45% <100.00%> (ø)
src/trace/context-utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e938882...8e3b8da. Read the comment docs.

Copy link
Member

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a breaking change an entry in upgrade guideline (introduced in #43) should be added

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once conflicts are resolved this can merge

@vmarchaud vmarchaud force-pushed the namespaced-utils branch from 124a8ee to d2dad62 Compare May 2, 2021 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider moving setSpan()/getSpan() to its related subsection
4 participants