-
Notifications
You must be signed in to change notification settings - Fork 47
chore: move span method for context in trace API #40 #47
Conversation
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 94.65% 94.72% +0.07%
==========================================
Files 39 40 +1
Lines 505 512 +7
Branches 80 80
==========================================
+ Hits 478 485 +7
Misses 27 27
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a breaking change an entry in upgrade guideline (introduced in #43) should be added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once conflicts are resolved this can merge
124a8ee
to
d2dad62
Compare
[sg]etSpan
/[sg]etSpanContext
utils into the trace API[sg]etBaggage
to the baggage folder (next tocreateBaggage
)Fixes #40