This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
OlivierAlbertini and
vmarchaud
as code owners
May 6, 2021 22:19
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 94.95% 94.99% +0.03%
==========================================
Files 40 41 +1
Lines 535 559 +24
Branches 92 94 +2
==========================================
+ Hits 508 531 +23
- Misses 27 28 +1
Continue to review full report at Codecov.
|
naseemkullah
reviewed
May 7, 2021
naseemkullah
approved these changes
May 7, 2021
vmarchaud
reviewed
May 7, 2021
dyladan
reviewed
May 7, 2021
vmarchaud
approved these changes
May 11, 2021
Merged
dyladan
approved these changes
May 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding component logger that will support namespace. New function to diag
createComponentLogger
.Fixes #61