Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

chore: document the reason for symbol.for #64

Merged
merged 2 commits into from
May 12, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 12, 2021

Documenting the reason for Symbol.for() in the code so that the reason we break from the spec is clear to new users and so we don't accidentally change to use Symbol() in the future.

@dyladan dyladan added the documentation Improvements or additions to documentation label May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #64 (acdb9b4) into main (6dda822) will not change coverage.
The diff coverage is n/a.

❗ Current head acdb9b4 differs from pull request most recent head 5de6aa8. Consider uploading reports for the commit 5de6aa8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   94.69%   94.69%           
=======================================
  Files          40       40           
  Lines         509      509           
  Branches       80       80           
=======================================
  Hits          482      482           
  Misses         27       27           
Impacted Files Coverage Δ
src/context/context.ts 82.35% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dda822...5de6aa8. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants