Skip to content

Commit

Permalink
chore: fix typos and minor README (#759)
Browse files Browse the repository at this point in the history
* chore: fix typos and minor README

* Update packages/opentelemetry-core/README.md

Co-Authored-By: Daniel Dyla <dyladan@users.noreply.github.com>

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
  • Loading branch information
mayurkale22 and dyladan authored Feb 3, 2020
1 parent d2e96ba commit de4c19e
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ Maintainers ([@open-telemetry/js-maintainers](https://github.com/orgs/open-telem

| Package | Description |
| ----------------------- | -----------------|
| [@opentelemetry/api][otel-api] | This package provides TypeScript interfaces and enums for the OpenTelemetry core trace and metrics model. It is intended for use both on the server and in the browser. |
| [@opentelemetry/api][otel-api] | This package provides TypeScript interfaces, enums and no-op implementations for the OpenTelemetry core trace and metrics model. It is intended for use both on the server and in the browser. |
| [@opentelemetry/core][otel-core] | This package provides default and no-op implementations of the OpenTelemetry api for trace and metrics. It's intended for use both on the server and in the browser. |

### Implementation / SDKs
Expand Down
2 changes: 1 addition & 1 deletion examples/postgres/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ app.get('/:cmd', (req, res) => {
let queryText = `SELECT id, text FROM test WHERE id = ${req.query.id}`;
if (cmd === 'insert') {
if (!req.query.text) {
res.status(400).send('No text provded');
res.status(400).send('No text provided');
return;
}
queryText = {
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
[![devDependencies][devDependencies-image]][devDependencies-url]
[![Apache License][license-image]][license-image]

This package provides default and no-op implementations of the OpenTelemetry types for trace and metrics. It's intended for use both on the server and in the browser.
This package provides default and no-op implementations of the OpenTelemetry API for trace and metrics. It's intended for use both on the server and in the browser.

## Useful links
- For more information on OpenTelemetry, visit: <https://opentelemetry.io/>
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-metrics/src/Meter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ export class Meter implements types.Meter {
/**
* Provide a pre-computed re-useable LabelSet by
* converting the unordered labels into a canonicalized
* set of lables with an unique identifier, useful for pre-aggregation.
* set of labels with an unique identifier, useful for pre-aggregation.
* @param labels user provided unordered Labels.
*/
static labels(labels: types.Labels): types.LabelSet {
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-scope-async-hooks/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ There are known modules that break scope propagation ([some of them are listed t

### Prior arts

Context propagation is a big subject when talking about tracing in NodeJS, if you want more informations about that here are some resources:
Context propagation is a big subject when talking about tracing in NodeJS, if you want more information about that here are some resources:
- https://www.npmjs.com/package/continuation-local-storage (which was the old way of doing context propagation)
- Datadog's own implementation for their Javascript tracer: [here][dd-js-tracer-scope]
- OpenTracing implementation: [here][opentracing-scope]
Expand Down

0 comments on commit de4c19e

Please sign in to comment.