Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(fix): host metrics readme snippet #1182

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Conversation

Eomm
Copy link
Contributor

@Eomm Eomm commented Sep 19, 2022

Which problem is this PR solving?

fixes #1014

Short description of the changes

The readme example is updated to a working snippet

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@Eomm Eomm requested a review from a team September 19, 2022 06:57
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 19, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Eomm / name: Manuel Spigolon (b9302ce)

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #1182 (63882a9) into main (e0a2e8e) will increase coverage by 0.30%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1182      +/-   ##
==========================================
+ Coverage   96.07%   96.37%   +0.30%     
==========================================
  Files          14       20       +6     
  Lines         892     1049     +157     
  Branches      191      201      +10     
==========================================
+ Hits          857     1011     +154     
- Misses         35       38       +3     
Impacted Files Coverage Δ
packages/opentelemetry-host-metrics/src/metric.ts 100.00% <0.00%> (ø)
...ges/opentelemetry-host-metrics/src/stats/common.ts 100.00% <0.00%> (ø)
...ackages/opentelemetry-host-metrics/src/stats/si.ts 66.66% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/util.ts 91.66% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/enum.ts 100.00% <0.00%> (ø)
...ages/opentelemetry-host-metrics/src/BaseMetrics.ts 100.00% <0.00%> (ø)

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for updating the docs 🙂

@legendecas legendecas merged commit 35d1e45 into open-telemetry:main Sep 20, 2022
@dyladan dyladan mentioned this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetricReader is not bound to a MetricProducer
4 participants