Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fastify): Skip update HTTP's span name and update RpcMetadata's route instead #1569

Merged
merged 4 commits into from
Jul 12, 2023

Conversation

chigia001
Copy link
Contributor

@chigia001 chigia001 commented Jul 12, 2023

Which problem is this PR solving?

Each framework has a different approach to updating Span's name and HTTP_ROUTE attribute. We want to delegate this to instrumentation-http for consistent's name and attribute
This PR fixes the above issue for fastify

Short description of the changes

  • Skip modifying HTTP's Span name directly in instrumentation-fastify code
  • Update route property of RpcMetadata
  • As instrumentation-fastify's unit test already integrate with instrumentation-http, there are no need to update any test

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1569 (73c7033) into main (bf25eb1) will decrease coverage by 0.72%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1569      +/-   ##
==========================================
- Coverage   96.06%   95.35%   -0.72%     
==========================================
  Files          14       20       +6     
  Lines         914     1183     +269     
  Branches      199      246      +47     
==========================================
+ Hits          878     1128     +250     
- Misses         36       55      +19     
Impacted Files Coverage Δ
...try-instrumentation-fastify/src/instrumentation.ts 97.60% <100.00%> (ø)

... and 5 files with indirect coverage changes

@pichlermarc pichlermarc merged commit 8d9687d into open-telemetry:main Jul 12, 2023
13 checks passed
@dyladan dyladan mentioned this pull request Jul 12, 2023
@chigia001 chigia001 deleted the fix-1381-fastify branch July 12, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants