-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(auto-instr-node): show result of setting both env vars #2325
Merged
blumamir
merged 6 commits into
open-telemetry:main
from
JamieDanielson:jamie.add-test-for-enable-and-disable
Jul 23, 2024
Merged
test(auto-instr-node): show result of setting both env vars #2325
blumamir
merged 6 commits into
open-telemetry:main
from
JamieDanielson:jamie.add-test-for-enable-and-disable
Jul 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OTEL_NODE_ENABLED_INSTRUMENTATIONS and OTEL_NODE_DISABLED_INSTRUMENTATIONS environment variables are mutually exclusive. All instrumentations are disabled when both are set.
github-actions
bot
requested review from
blumamir,
dyladan,
legendecas and
pichlermarc
July 11, 2024 21:07
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2325 +/- ##
==========================================
- Coverage 90.97% 90.40% -0.57%
==========================================
Files 146 149 +3
Lines 7492 7371 -121
Branches 1502 1532 +30
==========================================
- Hits 6816 6664 -152
- Misses 676 707 +31 |
maryliag
reviewed
Jul 16, 2024
trentm
requested changes
Jul 17, 2024
trentm
approved these changes
Jul 18, 2024
maryliag
approved these changes
Jul 18, 2024
blumamir
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
OTEL_NODE_ENABLED_INSTRUMENTATIONS
andOTEL_NODE_DISABLED_INSTRUMENTATIONS
environment variables are both set.Note this test is intended to show current state. If we want to change the behavior so that one wins over the other, that is an option, but is not the purpose of this PR.