Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto-config of baggage propagator #2425

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

joekhoobyar
Copy link
Contributor

Which problem is this PR solving?

  • When supplying OTEL_PROPAGATORS via an env var, baggage is mistakenly mapped to to the W3CTraceContextPropagator

Short description of the changes

  • properly map baggage to to the W3CBaggagePropagator

@joekhoobyar joekhoobyar requested a review from a team September 9, 2024 18:45
Copy link

linux-foundation-easycla bot commented Sep 9, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@joekhoobyar joekhoobyar changed the title Fix auto-config of baggage propagator fix: auto-config of baggage propagator Sep 9, 2024
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof, good catch - thanks for fixing this 👍

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.68%. Comparing base (dfb2dff) to head (ae9340e).
Report is 234 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/auto-configuration-propagators/src/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2425      +/-   ##
==========================================
- Coverage   90.97%   90.68%   -0.30%     
==========================================
  Files         146      156      +10     
  Lines        7492     7632     +140     
  Branches     1502     1575      +73     
==========================================
+ Hits         6816     6921     +105     
- Misses        676      711      +35     
Files with missing lines Coverage Δ
...ckages/auto-configuration-propagators/src/utils.ts 85.29% <0.00%> (ø)

... and 76 files with indirect coverage changes

@pichlermarc pichlermarc merged commit e87ff9d into open-telemetry:main Sep 10, 2024
16 of 18 checks passed
@dyladan dyladan mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants