Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix bugs in release workflow #417

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

willarmiros
Copy link
Contributor

Which problem is this PR solving?

  • Failed workflow run for 0.15.0

Short description of the changes

This change includes a few fixes/improvements to the publish workflow (which is run automatically after a release PR is merged).

  • Actually bootstrap the repo before publishing to avoid compile errors
  • Don't regenerate the changelog for the GitHub release entry, instead copy over the entry from the CHANGELOG.md file
  • Use lerna publish instead of the publish.sh script

I verified these changes in my test repo here.

My only concern that I can't validate is if there are any permissions/authentication issues with publishing scoped packages via CI, since I've seen that can cause issue: lerna/lerna#2788. @dyladan any concerns on this?

@willarmiros willarmiros requested a review from a team April 9, 2021 23:19
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #417 (ca66f68) into main (1381a9a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #417   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files          12       12           
  Lines         432      432           
  Branches       48       48           
=======================================
  Hits          407      407           
  Misses         25       25           

@willarmiros
Copy link
Contributor Author

Issue that I'm worried about for the auth issues: npm/cli#1637

It says it's fixed by npm login, but I don't know how to perform a login in CI. Unless a username and password secret were added to the repo.

@obecny
Copy link
Member

obecny commented Apr 14, 2021

make sure it is merged before releasing the next version of contrib @open-telemetry/javascript-approvers

@vmarchaud vmarchaud requested review from obecny and dyladan April 14, 2021 20:22
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vmarchaud vmarchaud merged commit 73b9c6b into open-telemetry:main Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants