-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: test multiple versions of pg
and pg-pool
#751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauno56
force-pushed
the
chore/pg-version-tests
branch
from
November 22, 2021 14:59
e32c3b6
to
cb52e66
Compare
Codecov Report
@@ Coverage Diff @@
## main #751 +/- ##
==========================================
- Coverage 96.87% 95.22% -1.66%
==========================================
Files 11 73 +62
Lines 640 6239 +5599
Branches 126 615 +489
==========================================
+ Hits 620 5941 +5321
- Misses 20 298 +278
|
rauno56
force-pushed
the
chore/pg-version-tests
branch
2 times, most recently
from
November 24, 2021 14:08
a95e8f9
to
426c722
Compare
rauno56
force-pushed
the
chore/pg-version-tests
branch
from
November 24, 2021 15:23
a19d0e9
to
c6aad06
Compare
... since there's none for pg.
rauno56
changed the title
chore: test more versions of pg and pg-pool
test: test multiple versions of Nov 26, 2021
pg
and pg-pool
vmarchaud
approved these changes
Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We claim support for 7.x and 8.x, but don't test to ensure that. Adding tests.
Short description of the changes
I'm adding TAV(
test-all-versions
package) setup for pg in this PR to test the most popular versions across the supported range:7.3.0
- errors on connecting to postgres v14, narrowing down thetest-utils
version to avoid contributors running into the same issue.7.12.1
7.18.2
8.5.1
8.6.0
8.7.1
7.x branch does not work with node 14+. I'm disabling TAV runs on those versions.
npm run test
still runs whatever the node version is.