Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test multiple versions of winston #760

Merged
merged 5 commits into from
Nov 30, 2021

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Nov 26, 2021

Which problem is this PR solving?

We claim support for 2.x and 3.x, but don't test to ensure that. Adding tests.

Short description of the changes

Adding TAV setup for winston to test the most popular versions across the supported range:

  • 3.3.3
  • 3.2.1
  • 2.4.5
  • 2.4.4
  • 2.1.1

@rauno56 rauno56 changed the title test: test multiple versions of winston test: test multiple versions of winston Nov 26, 2021
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #760 (cddaf86) into main (bdfbcd4) will decrease coverage by 19.45%.
The diff coverage is n/a.

❗ Current head cddaf86 differs from pull request most recent head d9ff29a. Consider uploading reports for the commit d9ff29a to get more accurate results

@@             Coverage Diff             @@
##             main     #760       +/-   ##
===========================================
- Coverage   96.87%   77.41%   -19.46%     
===========================================
  Files          11        3        -8     
  Lines         640      186      -454     
  Branches      126       18      -108     
===========================================
- Hits          620      144      -476     
- Misses         20       42       +22     
Impacted Files Coverage Δ
...etry-plugin-react-load/src/enums/AttributeNames.ts
...strumentation-document-load/src/instrumentation.ts
...lemetry-instrumentation-document-load/src/utils.ts
...trumentation-document-load/src/enums/EventNames.ts
...umentation-user-interaction/src/instrumentation.ts
...entation-document-load/src/enums/AttributeNames.ts
...ation-user-interaction/src/enums/AttributeNames.ts
...etapackages/auto-instrumentations-web/src/utils.ts
...lugin-react-load/src/BaseOpenTelemetryComponent.ts
...entelemetry-instrumentation-fastify/src/version.ts
... and 2 more

@rauno56 rauno56 force-pushed the test/winston-version-tests branch from f13d46a to 1f7ef74 Compare November 26, 2021 14:36
@rauno56 rauno56 marked this pull request as ready for review November 26, 2021 14:36
@rauno56 rauno56 requested a review from a team November 26, 2021 14:36
@dyladan dyladan merged commit 7bde622 into open-telemetry:main Nov 30, 2021
@rauno56 rauno56 deleted the test/winston-version-tests branch November 30, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants