-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource-detector-aws, resource-detector-gcp #2583
Comments
I'd find installing potentially unused detectors in every environment very unnecessary. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
#2698 can be one of the reasons that those detectors should not be static dependencies of sdk-node as they may load arbitrary vendor dependencies like gcp-metadata and significantly increase the load time of the sdk-node (gcp-metadata takes up ~20ms out of ~140ms sdk-node load time). |
At the time this issue was created we discussed it in SIG and agreed to remove the dependency from sdk-node we just never got around to actually making the change. |
Closing this as we've since removed those. #3024 |
Currently the package @opentelemetry/sdk-node from main repo depends on 2 packages from contrib repo
Those packages should be either moved to main repo or we should remove the dependency on them from @opentelemetry/sdk-node
both should work fine
The text was updated successfully, but these errors were encountered: