Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove aws and gcp detector from SDK #3024

Merged
merged 4 commits into from
Jun 8, 2022

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Jun 7, 2022

Which problem is this PR solving?

Short description of the changes

AWS and GCP detectors were moved to contrib.
NodeSDK should not depend on contrib resources.

Refs: #2392
Refs: #3018 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

AWS and GCP detectors were moved to contrib.
NodeSDK should not depend on contrib resources.
@Flarna Flarna requested a review from a team June 7, 2022 14:26
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #3024 (57be50f) into main (48e960a) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 57be50f differs from pull request most recent head 6c815d9. Consider uploading reports for the commit 6c815d9 to get more accurate results

@@            Coverage Diff             @@
##             main    #3024      +/-   ##
==========================================
- Coverage   92.78%   92.78%   -0.01%     
==========================================
  Files         185      185              
  Lines        6144     6142       -2     
  Branches     1300     1300              
==========================================
- Hits         5701     5699       -2     
  Misses        443      443              
Impacted Files Coverage Δ
...imental/packages/opentelemetry-sdk-node/src/sdk.ts 91.07% <ø> (-0.31%) ⬇️

@Flarna
Copy link
Member Author

Flarna commented Jun 8, 2022

Seems CI is broken, OTLPMetricExporter - node with TLS, without metadata - export - should export metrics fails consistent for some reason.

@Flarna Flarna force-pushed the no-contrib-deps branch from 95a9841 to 6c815d9 Compare June 8, 2022 09:54
@Flarna
Copy link
Member Author

Flarna commented Jun 8, 2022

regenerating certificates for GRPC exporters make CI green again

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

Thanks for fixing the certs too, I was wondering what is going on until I stumbled upon your PR. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants