-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove aws and gcp detector from SDK #3024
Conversation
AWS and GCP detectors were moved to contrib. NodeSDK should not depend on contrib resources.
Codecov Report
@@ Coverage Diff @@
## main #3024 +/- ##
==========================================
- Coverage 92.78% 92.78% -0.01%
==========================================
Files 185 185
Lines 6144 6142 -2
Branches 1300 1300
==========================================
- Hits 5701 5699 -2
Misses 443 443
|
Seems CI is broken, |
regenerating certificates for GRPC exporters make CI green again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙂
Thanks for fixing the certs too, I was wondering what is going on until I stumbled upon your PR. 😅
Which problem is this PR solving?
Short description of the changes
AWS and GCP detectors were moved to contrib.
NodeSDK should not depend on contrib resources.
Refs: #2392
Refs: #3018 (comment)
Type of change
How Has This Been Tested?
Checklist: