Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin/gRPC: patching does not work when used with makeGenericClientConstructor #327

Closed
markwolff opened this issue Sep 24, 2019 · 0 comments · Fixed by #325
Closed

Plugin/gRPC: patching does not work when used with makeGenericClientConstructor #327

markwolff opened this issue Sep 24, 2019 · 0 comments · Fixed by #325
Labels
bug Something isn't working

Comments

@markwolff
Copy link
Member

Please answer these questions before submitting a bug report.

What did you do?

If possible, provide a recipe for reproducing the error.
gRPC plugin currently patches makeClientConstructor. Example in #326 uses makeGenericClientConstructor, which is simply a re-export of the internal method makeClientConstructor. Patches should be applied to both of these functions.
@markwolff markwolff added the bug Something isn't working label Sep 24, 2019
@markwolff markwolff mentioned this issue Sep 24, 2019
Merged
@markwolff markwolff mentioned this issue Oct 18, 2019
Closed
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@DinaYakovlev @obecny @vmarchaud
feat: enable root span to contain route (open-telemetry#327)
384482c 
Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>
Co-authored-by: Valentin Marchaud <thisismac47@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(grpc): fix client/server span propagation markwolff/opentelemetry-js
1 participant
@markwolff