Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL security scans #1785

Merged
merged 5 commits into from
Jan 11, 2021

Conversation

amanbrar1999
Copy link
Contributor

Motivation

Follow up to issue open-telemetry/oteps#144

CodeQL is GitHub's static analysis engine which scans repos for security vulnerabilities. As the project grows and we near GA it might be useful to have a workflow which checks for security vulnerabilities with every PR so we can ensure every incremental change is following best development practices. Also passing basic security checks will also make sure that there aren't any glaring issues for our users.

Changes

  • This PR adds CodeQL security checks to the repo
  • After every run the workflow uploads the results to GitHub. Details on the run and security alerts will show up in the security tab of this repo.

Workflow Triggers

  • daily cron job at 1:30am
  • workflow_dispatch (in case maintainers want to trigger a security check manually)

cc- @alolita

@amanbrar1999 amanbrar1999 changed the title Add codeql security scans Add CodeQL security scans Dec 30, 2020
@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #1785 (1804a7e) into master (a5ca32b) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1785      +/-   ##
==========================================
+ Coverage   92.49%   92.50%   +0.01%     
==========================================
  Files         173      173              
  Lines        6019     6019              
  Branches     1287     1287              
==========================================
+ Hits         5567     5568       +1     
+ Misses        452      451       -1     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

@obecny obecny added the enhancement New feature or request label Jan 8, 2021
@dyladan
Copy link
Member

dyladan commented Jan 11, 2021

Please update the branch or make the PR editable by maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants