-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fixes after last changes to url #2214
Conversation
What was the root of the errors? I'm surprised the URL validation/normalization needed to be moved. |
packages/opentelemetry-exporter-collector-grpc/test/CollectorTraceExporter.test.ts
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2214 +/- ##
==========================================
- Coverage 93.68% 92.69% -0.99%
==========================================
Files 53 141 +88
Lines 1726 5106 +3380
Branches 358 1049 +691
==========================================
+ Hits 1617 4733 +3116
- Misses 109 373 +264
|
the normalization introduced a new variable whereas the url already existed and tests should always point to one param so this way it can be checked properly (the url is taken form config or environment or default). The environment params weren't normalized and as last something wrong has happened to the certificates, needed to recreate them again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing tests! 🎉
Which problem is this PR solving?
Short description of the changes