-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(otlp-http-exporter): update endpoint to match spec #2895
Merged
vmarchaud
merged 30 commits into
open-telemetry:main
from
svetlanabrennan:fix-general-endpoint
May 17, 2022
Merged
fix(otlp-http-exporter): update endpoint to match spec #2895
vmarchaud
merged 30 commits into
open-telemetry:main
from
svetlanabrennan:fix-general-endpoint
May 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
svetlanabrennan
force-pushed
the
fix-general-endpoint
branch
from
April 25, 2022 21:47
33cfc79
to
73daa78
Compare
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2895 +/- ##
==========================================
+ Coverage 92.51% 92.55% +0.03%
==========================================
Files 183 183
Lines 6029 6034 +5
Branches 1283 1284 +1
==========================================
+ Hits 5578 5585 +7
+ Misses 451 449 -2
|
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
…spec Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
…nal endpoints Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
…path to url Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
pichlermarc
approved these changes
May 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🙂
dyladan
approved these changes
May 11, 2022
/easycla |
JamieDanielson
approved these changes
May 11, 2022
legendecas
reviewed
May 16, 2022
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
legendecas
approved these changes
May 17, 2022
vmarchaud
approved these changes
May 17, 2022
This was referenced Jul 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Problem 1:
Spec says that
OTEL_EXPORTER_OTLP_ENDPOINT
is used for general endpoint so the http exporter doesn't have to check if a path is included in this endpoint. Our current implementation is checking for path in this endpoint.Fixes #2816
Problem 2:
Spec says that per-signal variables (
OTEL_EXPORTER_OTLP_<signal>_ENDPOINT
) should add a root path/
if the url contains no path part. Our current implementation doesn't check for root path and doesn't add root path.Short description of the changes
appendResourcePathToUrlIfNotPresent
toappendResourcePathToUrl
and removed logic around checking for path when user provides endpoint viaOTEL_EXPORTER_OTLP_ENDPOINT
.appendRootPathToUrlIfNeeded
that will append root path/
to url if needed.appendResourcePathToUrl
andappendRootPathToUrlIfNeeded
.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: