Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove domain from the Events API #4569

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

martinkuba
Copy link
Contributor

Which problem is this PR solving?

event domain was removed from the specification in this PR open-telemetry/opentelemetry-specification#3749.

Fixes # open-telemetry/opentelemetry-specification#2994

Short description of the changes

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@martinkuba martinkuba requested a review from a team March 21, 2024 17:15
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Merging #4569 (3a47029) into main (5fb65b4) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4569      +/-   ##
==========================================
+ Coverage   92.84%   92.85%   +0.01%     
==========================================
  Files         328      328              
  Lines        9494     9494              
  Branches     2040     2040              
==========================================
+ Hits         8815     8816       +1     
+ Misses        679      678       -1     
Files Coverage Δ
...ackages/api-events/src/NoopEventEmitterProvider.ts 100.00% <ø> (ø)
experimental/packages/api-events/src/api/events.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@pichlermarc pichlermarc merged commit fec6286 into open-telemetry:main Mar 25, 2024
20 checks passed
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
* removed domain from the events API

* lint

* updated changelog

---------

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants