Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Use (tree-shakeable) string constants for semconv #4739

Merged
merged 2 commits into from
May 31, 2024

Conversation

JohannesHuster
Copy link
Contributor

Which problem is this PR solving?

Updates #4567

Short description of the changes

Replace deprecated imports from “@opentelemetry/semantic-conventions” with new (tree-shakeable) string constants for core package. What I did:

  • Search for “@opentelemetry/semantic-conventions” in package path.
    • Add new imports and check that new and old strings match exactly.
    • Use new imports and remove old ones.

Type of change

  • Bug fix (non-breaking change which fixes an issue) (refactor)

How Has This Been Tested?

  • npm test

Checklist:

@JohannesHuster JohannesHuster requested a review from a team May 28, 2024 12:16
Copy link

linux-foundation-easycla bot commented May 28, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@pichlermarc pichlermarc added this pull request to the merge queue May 31, 2024
Merged via the queue into open-telemetry:main with commit ecc88a3 May 31, 2024
18 checks passed
@JohannesHuster JohannesHuster deleted the core-semconv branch June 1, 2024 15:08
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
…en-telemetry#4739)

* refactor(core): Use exported strings for semconv

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants