Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sdk-trace-node): Use tree-shakeable string constants for semconv #4748

Merged

Conversation

JohannesHuster
Copy link
Contributor

Which problem is this PR solving?

Updates #4567

Short description of the changes

Replace deprecated imports from @opentelemetry/semantic-conventions with new (tree-shakeable) string constants for package @opentelemetry/sdk-trace-node. What I did:

  • Search for “@opentelemetry/semantic-conventions” in package path.
    • Add new imports and check that new and old strings match exactly.
    • Use new imports and remove old ones.

Type of change

  • Bug fix (non-breaking change which fixes an issue) (refactor)

How Has This Been Tested?

  • npm test

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
    • No new functionality
  • Documentation has been updated

@JohannesHuster JohannesHuster marked this pull request as ready for review June 1, 2024 16:40
@JohannesHuster JohannesHuster requested a review from a team June 1, 2024 16:40
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx 🙂

@pichlermarc pichlermarc added this pull request to the merge queue Jun 3, 2024
Merged via the queue into open-telemetry:main with commit 7e72f1c Jun 3, 2024
17 of 18 checks passed
@JohannesHuster JohannesHuster deleted the sdk-trace-node-semconv branch June 3, 2024 17:29
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
…conv (open-telemetry#4748)

* refactor(sdk-trace-node): Use tree-shakeable string constants for semconv

* Update changelog

---------

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants