-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove binary propagator #804
Merged
dyladan
merged 5 commits into
open-telemetry:master
from
mayurkale22:remove_binary_format
Feb 27, 2020
Merged
chore: remove binary propagator #804
dyladan
merged 5 commits into
open-telemetry:master
from
mayurkale22:remove_binary_format
Feb 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
dyladan,
markwolff,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
February 20, 2020 22:36
OlivierAlbertini
approved these changes
Feb 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mayurkale22
force-pushed
the
remove_binary_format
branch
from
February 22, 2020 18:49
77a1c31
to
72449c7
Compare
Codecov Report
@@ Coverage Diff @@
## master #804 +/- ##
=========================================
+ Coverage 94.17% 94.4% +0.22%
=========================================
Files 242 242
Lines 10527 10627 +100
Branches 1027 1029 +2
=========================================
+ Hits 9914 10032 +118
+ Misses 613 595 -18
|
mayurkale22
added
the
needs-more-reviewers
PRs with this label are ready for review and needs more people to review to move forward.
label
Feb 24, 2020
@open-telemetry/javascript-approvers Please review when you get a chance. |
dyladan
approved these changes
Feb 25, 2020
obecny
approved these changes
Feb 26, 2020
dyladan
added
nonconforming
and removed
needs-more-reviewers
PRs with this label are ready for review and needs more people to review to move forward.
labels
Feb 27, 2020
1 task
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
* chore: remove binary format Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #762