Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove binary propagator #804

Merged
merged 5 commits into from
Feb 27, 2020

Conversation

mayurkale22
Copy link
Member

Follow-up of #762

Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Feb 24, 2020

Codecov Report

Merging #804 into master will increase coverage by 0.22%.
The diff coverage is 58.82%.

@@            Coverage Diff            @@
##           master    #804      +/-   ##
=========================================
+ Coverage   94.17%   94.4%   +0.22%     
=========================================
  Files         242     242              
  Lines       10527   10627     +100     
  Branches     1027    1029       +2     
=========================================
+ Hits         9914   10032     +118     
+ Misses        613     595      -18
Impacted Files Coverage Δ
...ckages/opentelemetry-plugin-express/src/version.ts 100% <ø> (ø) ⬆️
packages/opentelemetry-api/src/api/propagation.ts 58.82% <58.82%> (ø)
...kages/opentelemetry-plugin-dns/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
...ges/opentelemetry-plugin-https/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
packages/opentelemetry-plugin-dns/src/version.ts 100% <0%> (ø) ⬆️
...opentelemetry-base/test/resources/resource.test.ts 100% <0%> (ø) ⬆️
...s/opentelemetry-metrics/test/MeterProvider.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/config.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/utility.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-plugin-redis/src/version.ts 100% <0%> (ø) ⬆️
... and 25 more

@mayurkale22 mayurkale22 added the needs-more-reviewers PRs with this label are ready for review and needs more people to review to move forward. label Feb 24, 2020
@mayurkale22
Copy link
Member Author

@open-telemetry/javascript-approvers Please review when you get a chance.

@dyladan dyladan added nonconforming and removed needs-more-reviewers PRs with this label are ready for review and needs more people to review to move forward. labels Feb 27, 2020
@dyladan dyladan merged commit a34d03a into open-telemetry:master Feb 27, 2020
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
* chore: remove binary format

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants