Latest release (0.18.0) points to wrong image (local/opentelemetry-operator:e2e)

[gramidt]

The latest 0.18.0 release is pointing to the wrong image. Expectation is that it points to quay.io/opentelemetry/opentelemetry-operator.

Events:
  Type     Reason     Age                From               Message
  ----     ------     ----               ----               -------
...
  Normal   Pulling    19s (x3 over 58s)  kubelet            Pulling image "local/opentelemetry-operator:e2e"
  Warning  Failed     18s (x3 over 57s)  kubelet            Failed to pull image "local/opentelemetry-operator:e2e": rpc error: code = Unknown desc = Error response from daemon: pull access denied for local/opentelemetry-operator, repository does not exist or may require 'docker login': denied: requested access to the resource is denied
  Warning  Failed     18s (x3 over 57s)  kubelet            Error: ErrImagePull
  Normal   BackOff    6s (x3 over 56s)   kubelet            Back-off pulling image "local/opentelemetry-operator:e2e"
  Warning  Failed     6s (x3 over 56s)   kubelet            Error: ImagePullBackOff

[gramidt]

@jpkrohling - I'll try to dig in and determine what may have went wrong with the release process.

[jpkrohling]

This happens because the e2e step will override the image to use, here:

opentelemetry-operator/Makefile

Line 105 in e23224e

IMG=local/opentelemetry-operator:e2e

The target set-image-controller will then change the kustomize file here:

opentelemetry-operator/Makefile

Line 68 in e23224e

cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG}

On previous versions, we weren't changing it as we didn't have e2e tests. But now, either the publish step should use a fresh checkout, or we have to revert the changes before publishing the artifacts.

IIRC, this is the file that would need to be reverted:

opentelemetry-operator/config/manager/kustomization.yaml

Line 2 in e23224e

- manager.yaml

[gramidt]

@jpkrohling - I apologize, but may be misunderstanding you. I believe the issue stems from set-test-image-vars target is incorrect. First IMG is not indented with a tab, thus causing IMG to always be set to "local/opentelemetry-operator:e2e" for the entire Makefile. Second variable assignments in targets do not affect other targets by default. To get this to work as is without additional restructuring, eval is needed to set IMG globally, so the updated value is accessible in set-image-controller. I opened #171 yesterday with the this proposed change for your review.

[jpkrohling]

Sounds good. Would be good to confirm the cause of the issue by simulating the release workflow locally. If you can confirm that, and confirm that the fix works, I'll merge the PR and release 0.18.1

[gramidt]

For future reference: #171 (comment)