Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPD instrumentation: Safe modification of httpd.conf #3401

Closed
CostisC opened this issue Oct 28, 2024 · 2 comments
Closed

HTTPD instrumentation: Safe modification of httpd.conf #3401

CostisC opened this issue Oct 28, 2024 · 2 comments
Labels
bug Something isn't working needs triage

Comments

@CostisC
Copy link
Contributor

CostisC commented Oct 28, 2024

Component(s)

auto-instrumentation

What happened?

Description

The Include /usr/local/apache2/conf/opentemetry_agent.conf may be appended on the same line with the last httpd.conf statement, if there is not a blank last line in httpd.conf. This results in a corrupted httpd configuration, and the service will not start.

Steps to Reproduce

Change httpd.conf to not have an blank last line, and then restart the instrumented httpd pod. It fails to start up.

Expected Result

The Include /usr/local/apache2/conf/opentemetry_agent.conf statement should be appended as a separate last line, in httpd.conf settings.

Actual Result

E.g. the last lines of the new httpd.conf become:

<IfModule http2_module>
   <!-- omitted -->
</IfModule>Include /usr/local/apache2/conf/opentemetry_agent.conf

Kubernetes Version

v1.30.5-gke.1014001

Operator version

v0.107.0

Collector version

v0.14.0

Environment information

No response

Log output

No response

Additional context

No response
@CostisC CostisC added bug Something isn't working needs triage labels Oct 28, 2024
@CostisC
Copy link
Contributor Author

CostisC commented Oct 28, 2024

Suggested fix in PR #3395

swiatekm pushed a commit that referenced this issue Oct 28, 2024
@CostisC
HTTPD instrumentation: Safe modification of httpd.conf (#3395)
143c33c 
* HTTPD instrumentation: Safe modification of httpd.conf

* HTTPD instrumentation: added changelog file

* HTTPD instrumentation: added changelog file, for opened issue #3401
@jaronoff97
Copy link
Contributor

closed by #3395

@alexkruc alexkruc mentioned this issue Dec 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CostisC @jaronoff97