Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the target allocator on any manifest change #1027

Merged

Conversation

jaronoff97
Copy link
Contributor

This PR closes #1008 by removing the special target allocator behavior for not updating the container's spec. The desired behavior is to update the TA on a spec change. This also fixes a superfluous print from the operator that clogs operator logs due to the fact that the prometheus receiver has no endpoint to expose as it is a scrape based receiver.

Evidence of testing:

  targetAllocator:
    ...
    prometheusCR:
      enabled: false

There was no prometheusCR flag initially
Screen Shot 2022-08-09 at 4 09 04 PM

  targetAllocator:
    ...
    prometheusCR:
      enabled: true

Screen Shot 2022-08-09 at 4 09 25 PM

Screen Shot 2022-08-09 at 4 09 35 PM

@jaronoff97 jaronoff97 requested a review from a team August 9, 2022 20:13
@pavolloffay pavolloffay changed the title [1008] Update the target allocator on any manifest change Update the target allocator on any manifest change Aug 10, 2022
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, as the code owner (@Aneurysm9) has approved.

@jpkrohling jpkrohling merged commit 07b9f22 into open-telemetry:main Aug 10, 2022
@jaronoff97 jaronoff97 deleted the 1008-ta-update-on-cr-change branch August 10, 2022 18:19
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* Update the target allocator on any manifest change

* Change test to check for prometheusCR change validation

* Fix test

* Updated test to be more flexible for the future
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[target-allocator] TA pod doesn't restart when changing config settings
4 participants