Make sure we return the right version when autoscaling v2 is found #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Earls <kearls@redhat.com>
pavolloffay
reviewed
Sep 5, 2022
| @@ -117,10 +117,10 @@ func (v AutoscalingVersion) String() string { | |||
| return "unknown" | |||
| } | |||
|
|
|||
| func toAutoscalingVersion(version string) AutoscalingVersion { | |||
| func ToAutoScalingVersion(version string) AutoscalingVersion { | |||
There was a problem hiding this comment.
any reason why the function is public now?
There was a problem hiding this comment.
So it can be accessed by the test, as the test is in a different package
There was a problem hiding this comment.
It's a bit unfortunate/unnecessary to have the test in a different package in this case. But it was done like that from before so I will approve the PR.
pavolloffay
approved these changes
Sep 6, 2022
| @@ -117,10 +117,10 @@ func (v AutoscalingVersion) String() string { | |||
| return "unknown" | |||
| } | |||
|
|
|||
| func toAutoscalingVersion(version string) AutoscalingVersion { | |||
| func ToAutoScalingVersion(version string) AutoscalingVersion { | |||
There was a problem hiding this comment.
It's a bit unfortunate/unnecessary to have the test in a different package in this case. But it was done like that from before so I will approve the PR.
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…pen-telemetry#1075) Signed-off-by: Kevin Earls <kearls@redhat.com> Signed-off-by: Kevin Earls <kearls@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Earls kearls@redhat.com