Fix lint issues in target allocator

[kristinapathak]

I noticed that the target allocator files don't have a copyright at the top. Given how uniform it was, I'm not sure if this was intentional, but I added them here in case they are missing.

[Aneurysm9]

Should this repo include a license-check target that ensures these are present? We do this in the Go SDK.

[kristinapathak]

@Aneurysm9, I added the target you recommended - it runs as a part of basic checks:
https://github.com/open-telemetry/opentelemetry-operator/actions/runs/3046982755/jobs/4910456529

[kristinapathak]

Golang-ci is not running on target allocator code. I will be working on getting golang-ci to run on all go modules in the repo and fixing other lint issues in the target allocator.

[kristinapathak]

@pavolloffay, how was the configuration in .golangci.yaml decided? Other opentelemetry repos have golangci configured in a different way than this one, most notably for govet:
https://github.com/open-telemetry/opentelemetry-go-build-tools/blob/29a46c89ab69347be7d6f2c7f4f94135cb4d0d4f/.golangci.yml#L58
https://github.com/open-telemetry/opentelemetry-collector/blob/b1329c94b3b31b9ffa4091ab5066d6f091d71f41/.golangci.yml#L58
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/d2490af3003387cc4b1baa5b55f7d748303d7a4b/.golangci.yml#L56

There are many govet fieldalignment issues that look like this:

allocation/consistent_hashing.go:40:33: fieldalignment: struct with 64 pointer bytes could be 40 (govet)
type consistentHashingAllocator struct {

I'm not sure the best path forward to fix these specific fieldalignment issues.

[pavolloffay]

@pavolloffay, how was the configuration in .golangci.yaml decided?

I am not sure, probably back then I was not working in this repo. You could browse the PR history.

I am fine with disabling fieldalignment and aligning the golang-ci to other projects in the organization (if they use the same config).

[kristinapathak]

@pavolloffay, bringing the golangci.yaml into alignment with the golangci configs in opentelemetry-collector and opentelemetry-collector-contrib means even more lint fixes. I would rather disable fieldalignment in this PR, merge this, and then work on the next lint changes in a new PR. Is that okay with you?

[pavolloffay]

Is that okay with you?

Absoulutelly.

I am not sure why CI job Code standards (lining) didn't run

[pavolloffay]

maybe try to squash the commits and rebased the PR

[kristinapathak]

Further lint work: #1122

[kristinapathak]

@pavolloffay, I think there is an issue from Code standards (linting) being in a matrix now:

Continuous Integration / Code standards (linting) (.) (pull_request) 
Continuous Integration / Code standards (linting) (./cmd/otel-allocator) (pull_request) 

[pavolloffay]

could we remove this as well and reuse the header defined in the project root?