Fix Target Allocator builds by using versions.txt #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
approved these changes
Oct 4, 2022
secustor
approved these changes
Oct 4, 2022
johnphilip283
approved these changes
Oct 6, 2022
pavolloffay
reviewed
Oct 6, 2022
| @@ -8,7 +8,7 @@ opentelemetry-collector=0.60.0 | |||
| operator=0.60.0 | |||
|
|
|||
| # Represents the current release of the Target Allocator. | |||
| targetallocator=0.1.0 | |||
| targetallocator=0.60.0 | |||
There was a problem hiding this comment.
Should TA be released for every operator release? If so then it should be reflected in the release doc.
pavolloffay
approved these changes
Oct 7, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Rerun target allocator publish step * Docs which will trigger a publish * update release docs * update on new version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1139
This PR updates the target allocator's version to match the current operator release. I also updated the readme to reflect these changes. The code for getting the version is the same as the one found in the publish-images.yaml file.