New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reconcile otel collector on given context #1144

Merged

pavolloffay merged 1 commit into open-telemetry:main from frzifus:reconcile_on_given_ctx

Oct 6, 2022

Member

frzifus commented Oct 6, 2022

Saw randomly that a new context is created in the reconciler. Or is there a reason for this?


          reconcile otel collector on given context

acd01df

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>

frzifus requested a review from a team

October 6, 2022 13:47

pavolloffay approved these changes

View reviewed changes

Member

pavolloffay left a comment

Good catch!

pavolloffay merged commit c9a6505 into open-telemetry:main

frzifus deleted the reconcile_on_given_ctx branch

October 6, 2022 14:52

ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request


          Continue context in the collector controller (open-telemetry#1144)

a180bac

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet