Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change app image and context propagator b3 to b3multi in .Net e2e test case #1151

Conversation

avadhut123pisal
Copy link
Contributor

@avadhut123pisal avadhut123pisal commented Oct 8, 2022

Current docker image of the application used in the e2e test case for .Net auto-instrumentation throws error due to some dependency related issues. This PR replaces that image with the new sample asp .Net application image.

Also, previously for e2e test cases for .Net auto-instrumentation, b3 propagator was configured. But, as per the opentelemetry-dotnet-instrumentation release v0.3.0-beta.1, supported propagators are b3multi, baggage, tracecontext. So, with this PR b3 propagator is replaced with b3multi.

@avadhut123pisal avadhut123pisal requested a review from a team October 8, 2022 11:48
@avadhut123pisal avadhut123pisal changed the title Change app image and context propagator b3 to b3multi Change app image and context propagator b3 to b3multi in .Net e2e test case Oct 8, 2022
@@ -18,6 +18,6 @@ spec:
spec:
containers:
- name: myapp
image: docker.io/adib070/mvc
image: docker.io/avadhutp123/aspnetapp:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like an idea to reference private repositories/docked hub repositories here. It should be hosted in scope of OTel/OTel-test dockerhub.

Probably candidate for separate issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree !

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a comment there with a link to the source code?

Could you please also book an issue to to use app that is hosted in OTEL org or in this repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavolloffay Added the link to the source code repo and have raised the issue for consuming the apps that are hosted on OTEL org. #1155

@pavolloffay pavolloffay merged commit 5c65116 into open-telemetry:main Oct 10, 2022
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
…lemetry#1151)

* changes app image and context propagator b3 to b3multi

* adds source code repo link for the application
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants