Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix min tls setting for webhook server (#1225) #1230

Merged
merged 3 commits into from
Nov 8, 2022
Merged

fix min tls setting for webhook server (#1225) #1230

merged 3 commits into from
Nov 8, 2022

Conversation

kangsheng89
Copy link
Contributor

Fix issue #1225

@kangsheng89 kangsheng89 requested a review from a team November 8, 2022 06:34
pavolloffay
pavolloffay reviewed Nov 8, 2022
View reviewed changes
main.go Show resolved Hide resolved
@kangsheng89
Copy link
Contributor Author

@pavolloffay can help to approve for running workflow?

@kangsheng89
Copy link
Contributor Author

image
This is before change, where i portforward port from 9443 to localhost:10001

@kangsheng89
Copy link
Contributor Author

image
This is after fix, with portforward from 9443 to localhost:10001

As u can see, now the webhook server that run on port 9433 TLS setting enforce with v1.2 and above

@kangsheng89
Copy link
Contributor Author

kangsheng89 commented Nov 8, 2022 •
edited
Loading

let me check the comment, i think should add "." on it to make it pass the golangci-lint

@pavolloffay pavolloffay merged commit 82cf1bb into open-telemetry:main Nov 8, 2022
@kangsheng89 kangsheng89 deleted the min_tls branch November 9, 2022 01:58
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@kangsheng89
Fix min tls setting for webhook server (open-telemetry#1225) (open-te…
1b2baed 
…lemetry#1230)

* fix min tls setting for webhook server (open-telemetry#1225)

* using constant as setting

* fix godot issue on comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay pavolloffay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kangsheng89 @pavolloffay