Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create ServiceAccounts if existing ServiceAccount is not specified #1246

Merged

Conversation

csquire
Copy link
Contributor

@csquire csquire commented Nov 13, 2022

Fixes #1224

@csquire csquire requested a review from a team November 13, 2022 16:41
@csquire csquire changed the title Only create SAs if existing SA is not specified Only create ServiceAccounts if existing ServiceAccount is not specified Nov 13, 2022
@yuriolisa
Copy link
Contributor

@csquire, could you please add an example on README using the service account?

@pavolloffay
Copy link
Member

@csquire could you please as well add a note to

// ServiceAccount indicates the name of an existing service account to use with this instance.
and mention that if the SA is not provided the operator creates one.

@csquire, could you please add an example on README using the service account?

I would argue that this might be a corner use-case not needed for the readme that more focuses on quick-start guides.

@pavolloffay pavolloffay merged commit 6e10359 into open-telemetry:main Nov 21, 2022
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
…ed (open-telemetry#1246)

* Only create SAs if existing SA is not specified

* Add note to types about ServiceAccount creation

* Remove ServiceAccount from TA e2e test assertion, generate to update docs

* make bundle

* Update bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml

Co-authored-by: Ben B. <bongartz@klimlive.de>

* Update bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml

Co-authored-by: Ben B. <bongartz@klimlive.de>

* remove other invalid updates from make bundle

Co-authored-by: Ben B. <bongartz@klimlive.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not auto-create service account if an existing one is specified
5 participants