Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how images are pushed #138

Merged

Conversation

jpkrohling
Copy link
Member

@jpkrohling jpkrohling commented Dec 11, 2020

Changed how images are pushed to registries, both for master and releases.

@jpkrohling jpkrohling force-pushed the jpkrohling/36-publish-images branch 3 times, most recently from 2e39f13 to 5f4d970 Compare December 14, 2020 10:51
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling
Copy link
Member Author

@kevinearls, would you review this one as well?

Copy link
Member

@kevinearls kevinearls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


- name: Docker meta
id: docker_meta
uses: crazy-max/ghaction-docker-meta@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crazy-max? Should we be depending on someone named crazy-max? :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the exact thought. Unfortunately, the official docs for the Docker action recommends this one dynamic labels and tags.

@jpkrohling jpkrohling merged commit 3a39ff6 into open-telemetry:master Dec 14, 2020
@jpkrohling
Copy link
Member Author

I'm merging, as there's only one way of knowing it works.

This was referenced Dec 16, 2020
shree007 pushed a commit to shree007/opentelemetry-operator that referenced this pull request Dec 12, 2021
…try#138)

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
…try#138)

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants