Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenTelemetryCollectorSpec.Config docs #1680

Closed
wants to merge 1 commit into from
Closed

Update OpenTelemetryCollectorSpec.Config docs #1680

wants to merge 1 commit into from

Conversation

jroper
Copy link
Contributor

@jroper jroper commented Apr 27, 2023

The Config field contains YAML, not JSON.

@jroper
Update OpenTelemetryCollectorSpec.Config docs
313d5a2 
The Config field contains YAML, not JSON.
@jroper jroper requested a review from a team April 27, 2023 00:57
TylerHelmuth
TylerHelmuth reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaronoff97 can you add the Skip Changelog label? @jroper please run make bundle USER=open-telemetry VERSION=0.75.0

@jaronoff97 jaronoff97 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 27, 2023
@jaronoff97
Copy link
Contributor

@jroper it looks like you need to run make api-docs before we can merge this :)

pavolloffay
pavolloffay approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI :)

@jaronoff97 jaronoff97 added this to the v1alpha2 CRD release milestone Nov 28, 2023
@pavolloffay pavolloffay mentioned this pull request Apr 5, 2024
Merged
@pavolloffay
Copy link
Member

Done in #2819

@pavolloffay pavolloffay closed this Apr 5, 2024
@pavolloffay
Copy link
Member

thanks @jroper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth left review comments

@jaronoff97 jaronoff97 jaronoff97 approved these changes

@pavolloffay pavolloffay pavolloffay approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
Collector v1beta1 CRD release
Development

Successfully merging this pull request may close these issues.
4 participants
@jroper @jaronoff97 @pavolloffay @TylerHelmuth