Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Fields for V2 Types #2493

Merged
merged 7 commits into from
Jan 10, 2024
Merged

Conversation

jaronoff97
Copy link
Contributor

@jaronoff97 jaronoff97 commented Jan 8, 2024

Description:
Simplifies the shared fields between the CRDs.

Link to tracking Issue: resolves #901

Testing: n/a

Documentation: n/a

@jaronoff97 jaronoff97 marked this pull request as ready for review January 8, 2024 16:23
@jaronoff97 jaronoff97 requested a review from a team January 8, 2024 16:23
.chloggen/common-fields-v2.yaml Outdated Show resolved Hide resolved
apis/v1alpha2/common.go Outdated Show resolved Hide resolved
@jaronoff97 jaronoff97 enabled auto-merge (squash) January 10, 2024 17:23
@jaronoff97 jaronoff97 merged commit a339200 into open-telemetry:main Jan 10, 2024
27 checks passed
@jaronoff97 jaronoff97 deleted the common-fields-v2 branch January 10, 2024 17:23
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* common fields for v2 poc

* Docs and changelog

* fix deepcopy

* Remove more v1alpha1 deps, respond from comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed a PodTemplate or Container[] list in the OpentelemetryCollector CRD
3 participants